Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Rust code snippets to the tutorial (incl. CI execution) #450

Merged
merged 25 commits into from
Oct 24, 2024

Conversation

Sfonxu
Copy link
Contributor

@Sfonxu Sfonxu commented Sep 6, 2024

No description provided.

@slayoo slayoo closed this Sep 6, 2024
@slayoo slayoo reopened this Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (1c08c32) to head (5e02de1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          30       30           
  Lines        1468     1468           
=======================================
  Hits         1351     1351           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo
Copy link
Member

slayoo commented Oct 21, 2024

@Sfonxu, the CI build now fails with:

Error:   --> src/main.rs:43:60
   |
43 |     let stepper_arg = vec![("options", options),("n_dims", 2)].into_py_dict_bound(py);
   |                                                            ^ expected `Bound<'_, PyAny>`, found integer
   |
   = note: expected struct `pyo3::Bound<'_, PyAny>`
                found type `{integer}`

@Sfonxu
Copy link
Contributor Author

Sfonxu commented Oct 24, 2024

As to comment on changes made to readme_rust.yml file:

  • changed python toolchain version to v5
  • changed rust toolchain to dtolnay/rust-toolchain@stable
    This seems to have worked and successfully compiled the rust example

@slayoo slayoo changed the title rust hello world add Rust code snippets to the tutorial (incl. CI execution) Oct 24, 2024
@slayoo
Copy link
Member

slayoo commented Oct 24, 2024

kudos @Sfonxu !
Mergin, but also adding a new issue: #469

@slayoo slayoo merged commit 8fff7ce into open-atmos:main Oct 24, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants