Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffer distance into max_count and max_offset. #38

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

BG-AIMS
Copy link
Contributor

@BG-AIMS BG-AIMS commented Oct 13, 2024

Previously the buffering distance wasn't applied to max_count. Additionally have moved to max_offset to allow for full rotation of the search box without going outside of the rel_pix bounds. And adjusted options if there are no rel_pix for a search box (returns standard geometry to output valid DataFrame, but will be filtered out at later steps).

@BG-AIMS BG-AIMS self-assigned this Oct 13, 2024
@BG-AIMS BG-AIMS force-pushed the filter_relevant_pixels branch 2 times, most recently from 598f2cf to 5cac5c4 Compare October 14, 2024 05:57
@BG-AIMS BG-AIMS force-pushed the filter_relevant_pixels branch from c390682 to effe586 Compare October 24, 2024 04:55
@BG-AIMS BG-AIMS requested a review from arlowhite October 24, 2024 04:55
Previously the buffering distance wasn't applied to max_count. Additionally have moved to max_offset to allow for full rotation of the search box without going outside of the rel_pix bounds. And adjusted options if there are no rel_pix for a search box (returns standard geometry to output valid DataFrame, but will be filtered out at later steps).
Add max_count documentation and capping at 1
@BG-AIMS BG-AIMS force-pushed the filter_relevant_pixels branch from 8d66f2f to cc1aa10 Compare October 28, 2024 01:35
@ConnectedSystems ConnectedSystems changed the base branch from main to streamlined-process November 6, 2024 03:48
@ConnectedSystems
Copy link
Collaborator

Merging into streamlined-process branch instead of main.

@ConnectedSystems ConnectedSystems merged commit 8088a17 into streamlined-process Nov 6, 2024
1 check passed
@ConnectedSystems ConnectedSystems deleted the filter_relevant_pixels branch November 6, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants