-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync vLLM support from Examples repo k8s manifests to Helm charts #608
Comments
I think we should only have Helm charts. The GenAIExamples repository manifest should be deleted and enhance the Helm charts to support all the use cases. Now the project maintains the K8s deployment files in two different places which makes no sense. It is duplicate effort, error prone and leads to confusion. |
I'm working on adding similar vLLM support to ChatQnA & DocSum Helm charts: https://github.com/eero-t/GenAIInfra/commits/helm-vllm/ As I've never used "leaveEdgeCraftRAG" or "WorkflowExecAgent", I'll leave those to somebody else. Note that this support will require user specifying which LLM is to be used with the application, e.g. by using |
Yes. We're planning to move the helm charts from here to GenAIExamples and GenAIComps separately, and after that, we should delete those GenAIExample static k8s manifest files. |
@eero-t Yes, this is we should complete at 1.2 release cycle. Once this is done, #403 can be closed.
|
Several k8s app manifest and docker compose files in Examples repo support vLLM:
And k8s ones specify vLLM options in
configMap
:https://github.com/opea-project/GenAIExamples/blob/main/ChatQnA/kubernetes/intel/hpu/gaudi/manifest/chatqna-vllm.yaml#L178
However, such vLLM support is missing from application Helm charts here, and vLLM options are missing from the vLLM configMap in Helm charts:
https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/common/vllm/templates/configmap.yaml
Some of those options are specified with
ExtraCmdArgs
chart value in couple of other charts:Latter one uses those args only in the CI values file.
=> I think:
configMap
The text was updated successfully, but these errors were encountered: