Provide unified scalable deployment and benchmarking support for exam… #1315
+1,573
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjzhjing
requested review from
lvliang-intel,
ftian1 and
chensuyue
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
bjzhjing
force-pushed
the
unified-scalable-deployment
branch
from
eb2087e to
dee9960
Compare
|
The scripts looks good to me. But the benchmark folder here is not well adapt to the design philosophy of this Repo. We need to think about where and how to host those benchmark scripts. |
vrantala
reviewed
Jan 9, 2025
|
|
||
| # Pull and untar the chart | ||
| subprocess.run(["helm", "pull", chart_pull_url, "--untar"], check=True) | ||
|
|
There was a problem hiding this comment.
When we are pulling the the chart, should we also add --version parameter to it?
$ helm pull oci://localhost:5000/helm-charts/mychart --version 0.1.0
There was a problem hiding this comment.
Thanks for the comment, added the version support in new version.
bjzhjing
force-pushed
the
unified-scalable-deployment
branch
from
54c1ce8 to
29fbb2c
Compare
bjzhjing
force-pushed
the
unified-scalable-deployment
branch
2 times, most recently
from
8867800 to
c7715f4
Compare
…ples Signed-off-by: Cathy Zhang <[email protected]>
bjzhjing
force-pushed
the
unified-scalable-deployment
branch
from
35b3cdf to
67fe6db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide an unified approach to scalable deployment of AI examples in a Kubernetes environment, along with benchmarking.
Issues
This is to fix #1260 .
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.