update install bkc (#25)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
opea-project · Jun 1, 2024 · 26ddcc5 · 26ddcc5
1 parent b563b38
commit 26ddcc5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -6,14 +6,17 @@ Evaluation, benchmark, and scorecard, targeting for performance on throughput an
 - Install from Pypi
 
 ```bash
+pip install -r requirements.txt
 pip install opea-eval
 ```
+> notes: We have to install requirements.txt at first, cause Pypi can't have direct dependency with specific commit. 
 
 - Build from Source
 
 ```bash
 git clone https://github.com/opea-project/GenAIEval
 cd GenAIEval
+pip install -r requirements.txt
 pip install -e .
 ```
 

diff --git a/setup.py b/setup.py
@@ -3,18 +3,8 @@
 # Copyright (C) 2024 Intel Corporation
 # SPDX-License-Identifier: Apache-2.0
 
-#
-
-import subprocess
-
 from setuptools import find_packages, setup
 
-
-def parse_requirements(filename):
-    with open(filename, "r") as file:
-        return [line.strip() for line in file if line.strip() and not line.startswith("#")]
-
-
 setup(
     name="opea-eval",
     version="0.6",
@@ -25,6 +15,5 @@ def parse_requirements(filename):
     long_description_content_type="text/markdown",
     url="https://github.com/opea-project/GenAIEval",
     packages=find_packages(),
-    install_requires=parse_requirements("requirements.txt"),
     python_requires=">=3.10",
 )