[COR-2263] Remove suppress diff plan modifer for condition field and … #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winnie-opal
requested review from
amruth-opal and
andrewsy-opal
as code owners
amruth-opal
reviewed
Feb 6, 2025
…set default values
winnie-opal
force-pushed
the
winnie/cor-2263-remove-suppress-diff-plan-modifier-for-condition-field-and
branch
from
e140ff0 to
4892238
Compare
my bad, my pr got messed up after rebasing. fixed the files! |
amruth-opal
approved these changes
Feb 11, 2025
winnie-opal
deleted the
winnie/cor-2263-remove-suppress-diff-plan-modifier-for-condition-field-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…set default values
Description of the change
Removed suppress diff plan modifier for
conditionfield. This was causing a bug where updates that setconditionto null get ignored.Added default values for
conditionandrequire_mfa_to_approvefields.Checklist