Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: enable/disable experimental experiments using richer input #2554

Closed
bassosimone opened this issue Oct 10, 2023 · 1 comment
Closed
Assignees
Labels
enhancement improving existing code or new feature funder/drl2022-2024 ooni/probe-engine priority/medium techdebt This issue describes technical debt

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 10, 2023

This issue is about refactoring how we run experiments such that we always and unconditionally call check-in before any experiment (or group of experiments). In turn, this means that we have updated feature flags (which were introduced as part of richer input). In turn, this means that the information on whether to run experimental experiments is always fresh.

This issue is a follow-up of #2553.

As a reminder, experimental experiments are experiments that we just added, so we're not 100% sure about them, or experiments that are historically flaky, so we want to be defensive.

We should refactor quite soon because News Media Scan could be refactored soon not to use check-in, therefore the quick hack described in #2553 may soon become real technical debt.

Note: check-in flags expire after 24h, therefore the maximum window after which enabled-by-check-in experiments would be disabled again is 24h if the user does not perform any check-in in the meanwhile. That said, we still have potential future issues with News Media Scan, so better not to dally here 😅.

@bassosimone bassosimone self-assigned this Oct 10, 2023
@bassosimone bassosimone added priority/high techdebt This issue describes technical debt and removed priority/medium labels Oct 10, 2023
@bassosimone bassosimone changed the title engine: enabling experiment experiments using richer input engine: enable/disable experimental experiments using richer input Oct 11, 2023
@bassosimone
Copy link
Contributor Author

I've split this large issue into three issues for miniooni, mobile, and ooniprobe:

The original issue was a good placeholder but also too large. These three issues should be actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing code or new feature funder/drl2022-2024 ooni/probe-engine priority/medium techdebt This issue describes technical debt
Projects
None yet
Development

No branches or pull requests

1 participant