From 51bcd6e8e1f6153b0b5c7f2692530d99bb4e5327 Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Thu, 30 Nov 2023 13:52:10 +0100 Subject: [PATCH] cleanup(minipipeline): zap DNSPossiblyNonexistingDomains metric (#1416) What we can do with DNSPossiblyNonexistingDomains, we can also do with DNSLookupExpectedFailure. Part of https://github.com/ooni/probe/issues/2634 --- .../cmd/minipipeline/testdata/analysis.json | 3 +- .../testdata/analysis_classic.json | 3 +- internal/minipipeline/analysis.go | 69 ------------------- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../badSSLWithWrongServerName/analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../generated/dnsBlockingBOGON/analysis.json | 3 +- .../dnsBlockingBOGON/analysis_classic.json | 3 +- .../dnsBlockingNXDOMAIN/analysis.json | 3 +- .../dnsBlockingNXDOMAIN/analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../httpBlockingConnectionReset/analysis.json | 3 +- .../analysis_classic.json | 3 +- .../httpDiffWithConsistentDNS/analysis.json | 3 +- .../analysis_classic.json | 3 +- .../httpDiffWithInconsistentDNS/analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../generated/successWithHTTP/analysis.json | 3 +- .../successWithHTTP/analysis_classic.json | 3 +- .../generated/successWithHTTPS/analysis.json | 3 +- .../successWithHTTPS/analysis_classic.json | 3 +- .../tcpBlockingConnectTimeout/analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../analysis.json | 3 +- .../analysis_classic.json | 3 +- .../websiteDownNXDOMAIN/analysis.json | 5 +- .../websiteDownNXDOMAIN/analysis_classic.json | 5 +- .../manual/dnsgoogle80/analysis.json | 3 +- .../manual/dnsgoogle80/analysis_classic.json | 3 +- .../manual/noipv6/analysis.json | 3 +- .../manual/noipv6/analysis_classic.json | 3 +- .../manual/youtube/analysis.json | 3 +- .../manual/youtube/analysis_classic.json | 3 +- 69 files changed, 68 insertions(+), 209 deletions(-) diff --git a/internal/cmd/minipipeline/testdata/analysis.json b/internal/cmd/minipipeline/testdata/analysis.json index 63df47f530..c0e361316a 100644 --- a/internal/cmd/minipipeline/testdata/analysis.json +++ b/internal/cmd/minipipeline/testdata/analysis.json @@ -32,6 +32,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "x-drupal-cache": true, "x-generator": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/cmd/minipipeline/testdata/analysis_classic.json b/internal/cmd/minipipeline/testdata/analysis_classic.json index 16401b92ce..c0e361316a 100644 --- a/internal/cmd/minipipeline/testdata/analysis_classic.json +++ b/internal/cmd/minipipeline/testdata/analysis_classic.json @@ -32,6 +32,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "x-drupal-cache": true, "x-generator": true - }, - "DNSPossiblyNonexistingDomains": null + } } \ No newline at end of file diff --git a/internal/minipipeline/analysis.go b/internal/minipipeline/analysis.go index 29d099e5a8..d7abd95209 100644 --- a/internal/minipipeline/analysis.go +++ b/internal/minipipeline/analysis.go @@ -1,7 +1,6 @@ package minipipeline import ( - "github.com/ooni/probe-cli/v3/internal/netxlite" "github.com/ooni/probe-cli/v3/internal/optional" "github.com/ooni/probe-cli/v3/internal/runtimex" ) @@ -19,7 +18,6 @@ func AnalyzeWebObservations(container *WebObservationsContainer) *WebAnalysis { analysis.httpComputeFailureMetrics(container) analysis.httpComputeFinalResponseMetrics(container) - analysis.ComputeDNSPossiblyNonexistingDomains(container) return analysis } @@ -129,12 +127,6 @@ type WebAnalysis struct { // HTTPFinalResponseDiffUncommonHeadersIntersection contains the uncommon headers intersection. HTTPFinalResponseDiffUncommonHeadersIntersection optional.Value[map[string]bool] - - // TODO(bassosimone): there are probably redundant metrics from this point on - - // DNSPossiblyNonexistingDomains lists all the domains for which both - // the probe and the TH failed to perform DNS lookups. - DNSPossiblyNonexistingDomains optional.Value[map[string]bool] } func (wa *WebAnalysis) dnsComputeSuccessMetrics(c *WebObservationsContainer) { @@ -576,64 +568,3 @@ func (wa *WebAnalysis) httpDiffTitleDifferentLongWords(obs *WebObservation) { wa.HTTPFinalResponseDiffTitleDifferentLongWords = optional.Some(state) } - -// ComputeDNSPossiblyNonexistingDomains computes the DNSPossiblyNonexistingDomains field. -func (wa *WebAnalysis) ComputeDNSPossiblyNonexistingDomains(c *WebObservationsContainer) { - var state map[string]bool - - // first inspect the failures - for _, obs := range c.DNSLookupFailures { - // skip the comparison if we don't have enough information - if obs.DNSLookupFailure.IsNone() || obs.ControlDNSLookupFailure.IsNone() { - continue - } - - // flip state from None to empty when we see the first couple of - // (probe, th) failures allowing us to perform a comparison - if state == nil { - state = make(map[string]bool) - } - - // assume the domain is set in both cases - domain := obs.DNSDomain.Unwrap() - runtimex.Assert(domain == obs.ControlDNSDomain.Unwrap(), "mismatch between domain names") - - // a domain is nonexisting if both the probe and the TH say so - if obs.DNSLookupFailure.Unwrap() != netxlite.FailureDNSNXDOMAINError { - continue - } - if obs.ControlDNSLookupFailure.Unwrap() != "dns_name_error" { - continue - } - - // set the state - state[domain] = true - } - - // then inspect the successes - for _, obs := range c.DNSLookupSuccesses { - // skip the comparison if we don't have enough information - if obs.DNSLookupFailure.IsNone() && obs.ControlDNSLookupFailure.IsNone() { - continue - } - - // assume the domain is always set - domain := obs.DNSDomain.Unwrap() - - // clear the state if the probe succeeded - if !obs.DNSLookupFailure.IsNone() && obs.DNSLookupFailure.Unwrap() == "" { - delete(state, domain) - continue - } - - // clear the state if the TH succeded - if !obs.ControlDNSLookupFailure.IsNone() && obs.ControlDNSLookupFailure.Unwrap() == "" { - runtimex.Assert(domain == obs.ControlDNSDomain.Unwrap(), "mismatch between domain names") - delete(state, domain) - continue - } - } - - // note that optional.Some constructs None if state is nil - wa.DNSPossiblyNonexistingDomains = optional.Some(state) -} diff --git a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis.json index 1d83fa2694..e5548f7301 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis.json @@ -33,6 +33,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis_classic.json index be0c0442fe..1b6a4239fa 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithExpiredCertificate/analysis_classic.json @@ -31,6 +31,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis.json index 26acd175d5..7d816b0890 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis_classic.json index be0c0442fe..1b6a4239fa 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithConsistentDNS/analysis_classic.json @@ -31,6 +31,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis.json index 0fb4b1c2fa..8e461d4b0e 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis.json @@ -36,6 +36,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis_classic.json index 75146fc73a..004ce85c1e 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithUnknownAuthorityWithInconsistentDNS/analysis_classic.json @@ -31,6 +31,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis.json index 1d83fa2694..e5548f7301 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis.json @@ -33,6 +33,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis_classic.json index be0c0442fe..1b6a4239fa 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/badSSLWithWrongServerName/analysis_classic.json @@ -31,6 +31,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis.json index bc0fa5e4b6..666644b6e2 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis.json @@ -29,6 +29,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis_classic.json index bc0fa5e4b6..666644b6e2 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPSWebsite/analysis_classic.json @@ -29,6 +29,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis.json index 33fbc9053c..39e3c4ec65 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis.json @@ -29,6 +29,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis_classic.json index 33fbc9053c..39e3c4ec65 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/controlFailureWithSuccessfulHTTPWebsite/analysis_classic.json @@ -29,6 +29,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis.json index 7cd5c97dd9..b29cb58957 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis.json @@ -36,6 +36,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis_classic.json index 15398912a7..2f68abaeb4 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingAndroidDNSCacheNoData/analysis_classic.json @@ -29,6 +29,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis.json index 7fee6691aa..6acbdbb813 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis.json @@ -38,6 +38,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis_classic.json index dd43c1038c..b0e437e950 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingBOGON/analysis_classic.json @@ -31,6 +31,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis.json index a08799ab71..c13f4069c1 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis.json @@ -36,6 +36,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis_classic.json index b80999e7da..c7c8e85137 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsBlockingNXDOMAIN/analysis_classic.json @@ -29,6 +29,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis.json index 50667e2a1b..0709b9e1f1 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis.json @@ -37,6 +37,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis_classic.json index 9c2a6a7da8..3ebece0faa 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPSURL/analysis_classic.json @@ -34,6 +34,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": null + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis.json index 267554376a..3e326ceb99 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis.json @@ -36,6 +36,5 @@ "HTTPFinalResponseDiffTitleDifferentLongWords": {}, "HTTPFinalResponseDiffUncommonHeadersIntersection": { "content-length": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis_classic.json index dcd99d387f..84cf4d403b 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/dnsHijackingToProxyWithHTTPURL/analysis_classic.json @@ -33,6 +33,5 @@ "HTTPFinalResponseDiffTitleDifferentLongWords": {}, "HTTPFinalResponseDiffUncommonHeadersIntersection": { "content-length": true - }, - "DNSPossiblyNonexistingDomains": null + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis.json index 799739b255..dc9955aca9 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis_classic.json index 7ba1090eb4..d724331e61 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/httpBlockingConnectionReset/analysis_classic.json @@ -33,6 +33,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis.json index 78397ccb8f..1cf0d95020 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis.json @@ -37,6 +37,5 @@ "default": true, "denied": true }, - "HTTPFinalResponseDiffUncommonHeadersIntersection": {}, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": {} } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis_classic.json index 45fcacf752..d777dfada8 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithConsistentDNS/analysis_classic.json @@ -36,6 +36,5 @@ "default": true, "denied": true }, - "HTTPFinalResponseDiffUncommonHeadersIntersection": {}, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": {} } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis.json index 046e5b9f84..875c9ee456 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis.json @@ -38,6 +38,5 @@ "default": true, "denied": true }, - "HTTPFinalResponseDiffUncommonHeadersIntersection": {}, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": {} } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis_classic.json index ace161636e..1a620e123c 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/httpDiffWithInconsistentDNS/analysis_classic.json @@ -35,6 +35,5 @@ "default": true, "denied": true }, - "HTTPFinalResponseDiffUncommonHeadersIntersection": {}, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": {} } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis.json index 64de11e802..a643dfc3b6 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis.json @@ -40,6 +40,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis_classic.json index a1e35b70fc..5e51334e8b 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTP/analysis_classic.json @@ -38,6 +38,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis.json index 5472ca4622..550f85e6c9 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis.json @@ -37,6 +37,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis_classic.json index fb38908387..10823f59f0 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionRefusedForHTTPS/analysis_classic.json @@ -36,6 +36,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis.json index 5fbc95ec2c..4cd9d6e7e4 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis.json @@ -39,6 +39,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis_classic.json index 0b2d94b11f..8b99fb0b86 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTP/analysis_classic.json @@ -38,6 +38,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis.json index 6705a44d11..72e20888ca 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis.json @@ -37,6 +37,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis_classic.json index 35bc58726a..96728b6fe6 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenConnectionResetForHTTPS/analysis_classic.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis.json index 5fbc95ec2c..4cd9d6e7e4 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis.json @@ -39,6 +39,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis_classic.json index ca3bde64cf..c96863bccf 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTP/analysis_classic.json @@ -37,6 +37,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis.json index 6705a44d11..72e20888ca 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis.json @@ -37,6 +37,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis_classic.json index 0f1b10dbde..111da85674 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenEOFForHTTPS/analysis_classic.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenNXDOMAIN/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenNXDOMAIN/analysis.json index 1d83fa2694..e5548f7301 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenNXDOMAIN/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenNXDOMAIN/analysis.json @@ -33,6 +33,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenNXDOMAIN/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenNXDOMAIN/analysis_classic.json index 2dba858a1f..afc64a4fc0 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenNXDOMAIN/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenNXDOMAIN/analysis_classic.json @@ -32,6 +32,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTP/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTP/analysis.json index 5fbc95ec2c..4cd9d6e7e4 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTP/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTP/analysis.json @@ -39,6 +39,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTP/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTP/analysis_classic.json index 6f336bc155..98ae3617cc 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTP/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTP/analysis_classic.json @@ -37,6 +37,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTPS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTPS/analysis.json index 417334e676..ca480158d8 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTPS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTPS/analysis.json @@ -39,6 +39,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTPS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTPS/analysis_classic.json index 329c6276a8..58e20057a0 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTPS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/redirectWithConsistentDNSAndThenTimeoutForHTTPS/analysis_classic.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTP/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTP/analysis.json index f689adc8a0..d63d09e3ea 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTP/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTP/analysis.json @@ -36,6 +36,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTP/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTP/analysis_classic.json index 0e2f06f066..f0625a400a 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTP/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTP/analysis_classic.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": null + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTPS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTPS/analysis.json index 8542ab3b80..4496414f98 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTPS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTPS/analysis.json @@ -36,6 +36,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTPS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTPS/analysis_classic.json index 071e36f4d7..8fcbe6e0e8 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTPS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/successWithHTTPS/analysis_classic.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": null + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectTimeout/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectTimeout/analysis.json index 1749c4c197..eae46dca1c 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectTimeout/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectTimeout/analysis.json @@ -37,6 +37,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectTimeout/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectTimeout/analysis_classic.json index 4d0d3dc584..70c88127fa 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectTimeout/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectTimeout/analysis_classic.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectionRefusedWithInconsistentDNS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectionRefusedWithInconsistentDNS/analysis.json index 958fc1e091..19f9b9903a 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectionRefusedWithInconsistentDNS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectionRefusedWithInconsistentDNS/analysis.json @@ -40,6 +40,5 @@ "HTTPFinalResponseDiffUncommonHeadersIntersection": { "alt-svc": true, "content-length": true - }, - "DNSPossiblyNonexistingDomains": {} + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectionRefusedWithInconsistentDNS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectionRefusedWithInconsistentDNS/analysis_classic.json index c32fd84820..46471903c7 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectionRefusedWithInconsistentDNS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/tcpBlockingConnectionRefusedWithInconsistentDNS/analysis_classic.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithConsistentDNS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithConsistentDNS/analysis.json index a953b5b5a9..3d61ae2ee2 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithConsistentDNS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithConsistentDNS/analysis.json @@ -37,6 +37,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithConsistentDNS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithConsistentDNS/analysis_classic.json index 39ad5eb96e..aa697ed462 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithConsistentDNS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithConsistentDNS/analysis_classic.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithInconsistentDNS/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithInconsistentDNS/analysis.json index 4c26610614..c4688925ca 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithInconsistentDNS/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithInconsistentDNS/analysis.json @@ -39,6 +39,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": {} + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithInconsistentDNS/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithInconsistentDNS/analysis_classic.json index ce937b499c..ed5aac554e 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithInconsistentDNS/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/tlsBlockingConnectionResetWithInconsistentDNS/analysis_classic.json @@ -35,6 +35,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/websiteDownNXDOMAIN/analysis.json b/internal/minipipeline/testdata/webconnectivity/generated/websiteDownNXDOMAIN/analysis.json index 9caccaf793..1cf6020403 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/websiteDownNXDOMAIN/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/websiteDownNXDOMAIN/analysis.json @@ -30,8 +30,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": { - "www.example.xyz": true - } + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/generated/websiteDownNXDOMAIN/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/generated/websiteDownNXDOMAIN/analysis_classic.json index f8046188e3..e1c62c21ff 100644 --- a/internal/minipipeline/testdata/webconnectivity/generated/websiteDownNXDOMAIN/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/generated/websiteDownNXDOMAIN/analysis_classic.json @@ -29,8 +29,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": { - "www.example.xyz": true - } + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/manual/dnsgoogle80/analysis.json b/internal/minipipeline/testdata/webconnectivity/manual/dnsgoogle80/analysis.json index d67664afba..83db5f8d03 100644 --- a/internal/minipipeline/testdata/webconnectivity/manual/dnsgoogle80/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/manual/dnsgoogle80/analysis.json @@ -34,6 +34,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/manual/dnsgoogle80/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/manual/dnsgoogle80/analysis_classic.json index d67664afba..83db5f8d03 100644 --- a/internal/minipipeline/testdata/webconnectivity/manual/dnsgoogle80/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/manual/dnsgoogle80/analysis_classic.json @@ -34,6 +34,5 @@ "HTTPFinalResponseDiffBodyProportionFactor": null, "HTTPFinalResponseDiffStatusCodeMatch": null, "HTTPFinalResponseDiffTitleDifferentLongWords": null, - "HTTPFinalResponseDiffUncommonHeadersIntersection": null, - "DNSPossiblyNonexistingDomains": null + "HTTPFinalResponseDiffUncommonHeadersIntersection": null } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/manual/noipv6/analysis.json b/internal/minipipeline/testdata/webconnectivity/manual/noipv6/analysis.json index b95d960317..7724e8dfdf 100644 --- a/internal/minipipeline/testdata/webconnectivity/manual/noipv6/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/manual/noipv6/analysis.json @@ -36,6 +36,5 @@ "origin-trial": true, "permissions-policy": true, "report-to": true - }, - "DNSPossiblyNonexistingDomains": null + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/manual/noipv6/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/manual/noipv6/analysis_classic.json index b95d960317..7724e8dfdf 100644 --- a/internal/minipipeline/testdata/webconnectivity/manual/noipv6/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/manual/noipv6/analysis_classic.json @@ -36,6 +36,5 @@ "origin-trial": true, "permissions-policy": true, "report-to": true - }, - "DNSPossiblyNonexistingDomains": null + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/manual/youtube/analysis.json b/internal/minipipeline/testdata/webconnectivity/manual/youtube/analysis.json index 97afa28afb..c2a3e61512 100644 --- a/internal/minipipeline/testdata/webconnectivity/manual/youtube/analysis.json +++ b/internal/minipipeline/testdata/webconnectivity/manual/youtube/analysis.json @@ -37,6 +37,5 @@ "origin-trial": true, "permissions-policy": true, "report-to": true - }, - "DNSPossiblyNonexistingDomains": null + } } \ No newline at end of file diff --git a/internal/minipipeline/testdata/webconnectivity/manual/youtube/analysis_classic.json b/internal/minipipeline/testdata/webconnectivity/manual/youtube/analysis_classic.json index 1e06944fa2..696c5516e4 100644 --- a/internal/minipipeline/testdata/webconnectivity/manual/youtube/analysis_classic.json +++ b/internal/minipipeline/testdata/webconnectivity/manual/youtube/analysis_classic.json @@ -36,6 +36,5 @@ "origin-trial": true, "permissions-policy": true, "report-to": true - }, - "DNSPossiblyNonexistingDomains": null + } } \ No newline at end of file