From ed6a5df8539be594867c4ea72bfd739d9a6429d2 Mon Sep 17 00:00:00 2001
From: Simone Basso <bassosimone@gmail.com>
Date: Thu, 1 Jun 2023 11:38:02 +0000
Subject: [PATCH] fix(fbmessenger): attempt to improve data analysis

Based on feedback from @hellais
---
 pkg/experiment/fbmessenger/fbmessenger.go | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/pkg/experiment/fbmessenger/fbmessenger.go b/pkg/experiment/fbmessenger/fbmessenger.go
index 0e4be65..e2ceaff 100644
--- a/pkg/experiment/fbmessenger/fbmessenger.go
+++ b/pkg/experiment/fbmessenger/fbmessenger.go
@@ -174,6 +174,11 @@ func (tk *TestKeys) update(consistent, reachable *optional.Value[bool], observat
 	// if not consistent, update DNS blocking.
 	if !consistent.IsNone() && !consistent.Unwrap() {
 		tk.FacebookDNSBlocking = optional.Some(true)
+		// TODO(bassosimone): we should make sure we're following the spirit of the spec,
+		// which the code below is trying to follow more closely.
+		tk.FacebookTCPBlocking = optional.Some(false)
+		*reachable = optional.Some(false)
+		return
 	}
 
 	// determine whether the TCP endpoint was reachable.