This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Triggers firing for all window extents #640

Closed

JKelly95 opened this issue Aug 22, 2016 · 1 comment

Labels

bug

JKelly95 commented Aug 22, 2016

Triggers are firing for all window extents, despite setting :trigger/fire-all-extents? to false. In the following code I think you intended to compare :event-type to :new-segment, not :segment.
https://github.com/onyx-platform/onyx/blob/0.9.x/src/onyx/peer/window_state.clj#L141

MichaelDrogalis added the bug label

Member

lbradstreet commented Aug 22, 2016

Yes, it looks like you're right. Thank you for the report. We'll add a new test, get it fixed up, and cut a new release.

Thanks

lbradstreet closed this as completed in

065c7dd

lbradstreet mentioned this issue

Add test for trigger/fire-all-extents? #647

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.