Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Plugins may place task metadata in the replica which should be cleaned up #284

Closed
lbradstreet opened this issue Sep 2, 2015 · 2 comments

Comments

@lbradstreet
Copy link
Member

The onyx-kafka plugin now places metadata under [:task-metadata job-id task-id]. There isn't really any great way for the plugins to clean this up, as tasks may die, and we can't override or chain log commands. I think [:task-metadata job-id] should be dissoc-in'd when a job is completed.

@MichaelDrogalis?

@MichaelDrogalis
Copy link
Contributor

Yes, absolutely. As long as all plugins follow the convention to key their metadata under job-id, and then again under task-id, this is good. Also remember to dissoc on kill and garbage collection.

@lbradstreet
Copy link
Member Author

Closed via #287

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants