Airtable connector #3564
Merged
Airtable connector #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
force-pushed
the
airtable-connector
branch
from
4a86788 to
d0c4a42
Compare
| icon: AirtableIcon, | ||
| displayName: "Airtable", | ||
| category: SourceCategory.Other, | ||
| docs: "https://docs.onyx.app/connectors/airtable", |
There was a problem hiding this comment.
docs link doesn't exist yet
| def _should_be_metadata(self, field_type: str) -> bool: | ||
| """Determine if a field type should be treated as metadata.""" | ||
| # NOTE: all are made lowercase to avoid case sensitivity issues | ||
| metadata_field_types = { |
There was a problem hiding this comment.
maybe this should be a class var / constant?
There was a problem hiding this comment.
Done! I did this for closer proximity between definition and use (e.g. no need to scroll up to check if something is metadata), but I can see both ways being good (e.g. this allows for easier re-use of the metadata types)
| ) | ||
|
|
||
| record_document = Document( | ||
| id=str(record_id), |
There was a problem hiding this comment.
odds of a collision here are probably low due to how the id's are formatted, but a prefix on the document id has helped avoid them in other connectors.
rkuo-danswer
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Airtable connector.
How Has This Been Tested?
"Unit" test + manually creating connector + running it locally.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.