Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image generation doesn't work in air gapped systems #2091

Closed
emerzon opened this issue Aug 9, 2024 · 3 comments
Closed

Image generation doesn't work in air gapped systems #2091

emerzon opened this issue Aug 9, 2024 · 3 comments

Comments

@emerzon
Copy link
Contributor

emerzon commented Aug 9, 2024

Today, a image generation requires a second call to an external Azure Endpoint in order to retrieve the generated image. This won't work in air-gapped system as they will not have access to this external URL.

Ideally the image generation should rely on receiving the image inline in b64 format, as part of the model response.

An initial PR was crafted at #1861, however a lot has changed in how images are handled internally and this PR no longer works, and would need to be adapted.

@emerzon emerzon changed the title Support image generation doesn't work in air gapped systems Image generation doesn't work in air gapped systems Aug 9, 2024
Copy link

This issue is stale because it has been open 75 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Oct 25, 2024
@emerzon
Copy link
Contributor Author

emerzon commented Oct 31, 2024

Bumping as issue still relevant

@github-actions github-actions bot removed the Stale label Nov 1, 2024
@emerzon
Copy link
Contributor Author

emerzon commented Dec 5, 2024

Implemented in #3342

@emerzon emerzon closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant