CallToAction incorrectly extends HTMLAttributes

[dawaltconley]

HTMLAttributes takes a string as its generic, currently it's being passed an undefined type a.

export interface CallToAction extends HTMLAttributes<a> {
  // ...
}

However, Astro throws type errors if pass a type like this to a component with spread syntax, because of the slot property. So the correct typing would be:

export interface CallToAction extends Omit<HTMLAttributes<'a'>, 'slot'> {
  // ...
}

[prototypa]

Hi @dawaltconley

Thank you for this. Let's work on it. If you have noticed more details like this related to typescript, please let us know.

[dawaltconley]

Sure, I can collect in a fork. The main other thing I've noticed is typecasting Astro.props, I believe this doesn't enforce typings when passing props to astro components. I.e. in the Content widget:

import type { Content } from '~/types';
const {
   // ...props...
} = Astro.props as Content;

This should be changed to

import type { Content } from '~/types';
export type Props = Content // astro uses a type/interface of this name to type its props
const {
   // ...props...
} = Astro.props;

or just

import type { Content as Props } from '~/types';
const {
   // ...props...
} = Astro.props;

[prototypa]

Hi @dawaltconley

With your PR and with some adjustments that I made based on the comment you put in the PR about missing types, AstroWind now passes the astro check validation

• WIP: Type fixes #399
• a2187f0

Thanks, I'm going to close the Issue.