Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the agents links as any other compel objects in the models #123

Closed
jonquet opened this issue Jan 11, 2024 · 2 comments
Closed

Comments

@jonquet
Copy link

jonquet commented Jan 11, 2024

This is about implementing agents also as links to stay consistent with what was done for other complex objects in the models.
E.g., https://data.agroportal.lirmm.fr/ontologies/AGRO/metrics

For the moment links contains:
image

And agents are directly included in the submission like this
Capture d’écran 2024-01-11 à 18 28 52

So a call like this does not work :
https://data.agroportal.lirmm.fr/ontologies/AGRO/agents

If include=all is done on the /submission endpoint, then the data shall be grabed from the links and put in the outpiut explicilty.
This policy can also be generalized to any "links" that does not return too much data (basically that are about metadata) : metrics, reviews, notes, groups, categories, projects, analytics.
I would keep out the links that can possibly return too much data: submissions, properties, classes, roots, schemes, collections, instances, views

@jonquet
Copy link
Author

jonquet commented Jan 11, 2024

Working on this, I suggest to change the capital A in the service to a lower case a:
https://data.agroportal.lirmm.fr/Agents/f8c13b10-7b3e-013c-7b07-5254006dce65
in the json returned by the submission
https://data.agroportal.lirmm.fr/ontologies/AGRO/latest_submission?display=endorsedBy&display_context=false

@syphax-bouazzouni
Copy link

done in #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants