Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation breaks with specific combinations of portals #909

Closed
galviset opened this issue Jan 9, 2025 · 3 comments
Closed

Federation breaks with specific combinations of portals #909

galviset opened this issue Jan 9, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@galviset
Copy link

galviset commented Jan 9, 2025

Observered in the EarthPortal: when selecting AgroPortal and EcoPortal (without BiodivPortal), the UI returns We're sorry but something has gone wrong. We have been notified of this error.. Any other federated portal combination works on my side.

When digging into the logs, this is what is shown:

F, [2025-01-09T17:09:09.206470 #5170] FATAL -- :   
NoMethodError (undefined method `[]=' for nil:NilClass):
  
app/controllers/concerns/submission_filter.rb:74:in `block in merge_by_acronym'
app/controllers/concerns/submission_filter.rb:72:in `each'
app/controllers/concerns/submission_filter.rb:72:in `merge_by_acronym'
app/controllers/concerns/submission_filter.rb:50:in `submissions_paginate_filter'
app/controllers/ontologies_controller.rb:47:in `block in ontologies_filter'
app/controllers/ontologies_controller.rb:46:in `ontologies_filter'

Which leads to this function:

ontology[:sources] = ontologies.map { |x| x[:id] }

I didn't have the time to dig in, but it seems there is an edge case when it comes to handling acronyms.

@syphax-bouazzouni
Copy link
Collaborator

@galviset , can you copy us the link that does break in EarthPortal, that does show the error.

@syphax-bouazzouni syphax-bouazzouni added the bug Something isn't working label Jan 10, 2025
@galviset
Copy link
Author

This is on the browse page, the error is displayed instead of the list of ontologies
https://earthportal.eu/ontologies/?sort_by=ontology_name&portals=agroportal%2Cecoportal

@Bilelkihal
Copy link
Collaborator

Fixed here: #913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants