Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable fairness from env variable is not working #881

Closed
imadbourouche opened this issue Dec 4, 2024 · 1 comment
Closed

Enable/Disable fairness from env variable is not working #881

imadbourouche opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@imadbourouche
Copy link
Member

imadbourouche commented Dec 4, 2024

Context

When you run bioportal_web_ui, you can enable or disable fairness by changing the env variable FAIRNESS_DISABLED. This is not working because environment variables are always strings, and we not explicitly convert them into booleans in the ruby code.

  • with FAIRNESS_DISABLED=false or with FAIRNESS_DISABLED=true, fair score will not work

fair_not_working

@imadbourouche imadbourouche added the bug Something isn't working label Dec 4, 2024
@imadbourouche imadbourouche self-assigned this Dec 4, 2024
@syphax-bouazzouni
Copy link
Collaborator

syphax-bouazzouni commented Dec 9, 2024

fixed in 0c9adac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants