Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotator returns result with multiple languages (instead of english only) #577

Closed
Bilelkihal opened this issue Apr 16, 2024 · 6 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Bilelkihal
Copy link
Collaborator

The annotator returns result with different languages, while it's supposed to return them in english only

image

@Bilelkihal Bilelkihal added the bug Something isn't working label Apr 16, 2024
@Bilelkihal Bilelkihal self-assigned this Apr 16, 2024
@Bilelkihal
Copy link
Collaborator Author

This is not related to the new annotator's ui code,
image

The annotator's service returns results in multiple languages.
Group 2305

As a proposition to not go into the annotators code, we can in the UI fetch every concept by its id then display the default pref label of it which is in english,
@jonquet What do you think ?

@jonquet
Copy link

jonquet commented Apr 24, 2024

Hello. This is probably a change/bug introduced when we implemented the multilingual support.
We can see that the match (against the Annotator Redis dictionnary) was made with "Air temperature" in AGROVOC. The issue come from the call to retrieve the Class object from the key we have back from the MGREP tool. We might have not put the default language or something like this in this call.. so when there are multiple labels (as in AGROVOC but not in AGRO) we get one prefLabel randomly.

@syphax-bouazzouni
Copy link
Collaborator

@Bilelkihal did you try to add to the annotator api call, the language parameter (e.g lang=en)

@Bilelkihal
Copy link
Collaborator Author

Yes, adding lang param changes nothing.
what do you think, we do a solution in the UI by getting the english preflab for each concept, or we keep this issue open till we decide to get into the problems in annotator's repo?

@jonquet
Copy link

jonquet commented May 2, 2024

Pour moi c'est un changement sur l'Annoator back end a faire puisque le service web renvoie pas non plus ce qu'il faut.

@syphax-bouazzouni
Copy link
Collaborator

fixed in ontoportal-lirmm/ontologies_api#82 and deployed on StagePortal, will be deployed with Release 2.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants