Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add models: File and Commit #13

Closed
eugenk opened this issue Sep 26, 2016 · 5 comments · Fixed by #41
Closed

Add models: File and Commit #13

eugenk opened this issue Sep 26, 2016 · 5 comments · Fixed by #41
Assignees
@ebolloff
Milestone
Minimal git integ...

Comments

@eugenk
Copy link
Member

eugenk commented Sep 26, 2016

A File shall have

  • a path
  • a Commit

A Commit shall have

  • shasum
  • a Repository
  • an author (User - optional)
  • an editor (User - optional)
  • an author-name
  • an author-time
  • an editor-name
  • an editor-time
@eugenk eugenk added this to the Minimal git integration milestone Sep 26, 2016
@eugenk eugenk mentioned this issue Sep 26, 2016
Closed
@ebolloff
Copy link
Member

ebolloff commented Dec 9, 2016

If we name the model file we have a conflict with Ruby's File. I named it FileVersion for now. Any suggetions @phyrog @eugenk?

@ebolloff ebolloff self-assigned this Dec 9, 2016
@ebolloff
Copy link
Member

ebolloff commented Dec 9, 2016

Should the file have the url_path or just the path?

@ebolloff ebolloff mentioned this issue Dec 9, 2016
Merged
@eugenk
Copy link
Member Author

eugenk commented Dec 10, 2016

How about RepositoryFile?

@eugenk
Copy link
Member Author

eugenk commented Dec 10, 2016

Every model should have a url_path which points to the resource on the web. A File should have a path as well, which is the path of the file inside the repository. Maybe we should call it filepath, but it seems a little redundant to me.

@ebolloff
Copy link
Member

We'll stay with FileVersion.

@eugenk eugenk mentioned this issue Feb 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebolloff ebolloff

Labels
None yet
Projects
None yet
Milestone
Minimal git integration
Development

Successfully merging a pull request may close this issue.

13 add models file and commit ontohub/ontohub-models
2 participants
@eugenk @ebolloff