Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to collect stack for hanging tests when run in parallel #323

Closed
vito opened this issue Feb 17, 2017 · 3 comments
Closed

Hard to collect stack for hanging tests when run in parallel #323

vito opened this issue Feb 17, 2017 · 3 comments

Comments

@vito
Copy link
Contributor

vito commented Feb 17, 2017

We often run tests with -p or -nodes=X (both in CI and during dev). Unfortunately this makes it impossible to get a stack dump when the tests are hanging. If you send SIGQUIT to the toplevel ginkgo process you just get a stack dump of the coordinating node, not the nodes actually running the tests. If you send SIGQUIT to the nodes running the tests, the coordinating node just prints:

	 -------------------------------------------------------------------
	|                                                                   |
	|  Ginkgo timed out waiting for all parallel nodes to report back!  |
	|                                                                   |
	 -------------------------------------------------------------------

It'd be super handy if ginkgo trapped SIGQUIT, dispatched it to each of its nodes, collected their output, and then printed them non-interleaved. It should probably also do its own stack dump + exit, in case things are stuck there.

@onsi
Copy link
Owner

onsi commented Feb 17, 2017

Yes. Trapping and retransmitting would be the way to go here. I believe it already does this for SIGINT.

.......PR?

@MissingRoberto
Copy link

Same here. It's really tricky to find out the hanging test.

@onsi
Copy link
Owner

onsi commented Apr 6, 2021

Interrupts are handled much more cleanly now in v2 - sending SIGINT should get you a much clearer sense of where things are hanging.

@onsi onsi closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants