Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Clang 3.4 #428

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Support Clang 3.4 #428

merged 2 commits into from
Nov 4, 2020

Conversation

AlexanderLanin
Copy link
Contributor

While the compiler is rather old it seems trivial enough to support Clang 3.4.
Although I basically have no idea what the effects of this small change are...
I personally don't care much about performance on this old compiler.

Note: it's also possible to add clang-3.4 to GitHub Actions. I can add this to the pull request if you like.
It's something like:

            if [ "${{ matrix.config.version }}" = "3.4" ]; then
              echo "CC=clang" >> $GITHUB_ENV
              echo "CXX=clang++" >> $GITHUB_ENV
              echo "CXXFLAGS=-stdlib=libc++" >> $GITHUB_ENV

              # clang-3.4 is available from trusty
              sudo add-apt-repository "deb http://dk.archive.ubuntu.com/ubuntu/ trusty main"
              sudo add-apt-repository "deb http://dk.archive.ubuntu.com/ubuntu/ trusty universe"
            fi
            sudo apt install -y clang-${{ matrix.config.version }} g++-multilib

Clang 3.4 does not understand attribute noinline
@onqtam
Copy link
Member

onqtam commented Nov 4, 2020

Thanks for the PR! I don't think it's necessary to re-add clang 3.4 to the build matrix - I removed it more than 1 year ago

@onqtam onqtam merged commit 9a48082 into doctest:dev Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants