Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most of the issues reported in #253. One issue that remains is that
DOCTEST_LIBRARY_IMPLEMENTATION
in doctest.cpp is reported as unused. I'm suspecting it probably isn't so the solution might be to just ignore the warning.(Note that I had to remove
EXCLUDE_FROM_ALL
fromdoctest_with_main
to trigger most of the warnings fixed in this pr).