Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the GitHub CI builds are failing #334

Closed
claremacrae opened this issue Feb 7, 2020 · 1 comment
Closed

Some of the GitHub CI builds are failing #334

claremacrae opened this issue Feb 7, 2020 · 1 comment

Comments

@claremacrae
Copy link
Contributor

Description

Some of the GitHub CI builds are failing

Steps to reproduce

View the GitHub Actions logs:

https://github.com/onqtam/doctest/actions

Extra information

I'm intending to see if I can fix this, as I would like to crib some of the GitHub workflow configuration in this project, and would like it to be passing before I do that! 😄
@claremacrae
Copy link
Contributor Author

For the Windows failing builds, the error message is:

At D:\a\_temp\384af4b7-bfae-4079-891c-d5392beae9ba.ps1:5 char:10
+ cd build && ctest
+          ~~
The token '&&' is not a valid statement separator in this version.
+ CategoryInfo          : ParserError: (:) [], ParseException
+ FullyQualifiedErrorId : InvalidEndOfLine
 
##[error]Process completed with exit code 1.

I'll try fixing this by splitting the line in to two.

claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Fix Github Actions CI on Windows (doctest#334)
1a22383 
The output was:

At D:\a\_temp\384af4b7-bfae-4079-891c-d5392beae9ba.ps1:5 char:10
+ cd build && ctest
+          ~~
The token '&&' is not a valid statement separator in this version.
+ CategoryInfo          : ParserError: (:) [], ParseException
+ FullyQualifiedErrorId : InvalidEndOfLine

I've split all 'cd build && ctest' lines, to avoid making future
edits error-prone
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Fix clang Github Actions CI on Windows (doctest#334)
9699d60 
The output was:

AIn file included from ../examples/all_features/main.cpp:2:
 In file included from ../scripts/development_only\doctest/doctest.h:5:
 ../doctest/parts\doctest.cpp:142:10: error: non-portable path to file '<Windows.h>'; specified path differs in case from file name on disk [-Werror,-Wnonportable-system-include-path]
 #include <windows.h>
          ^~~~~~~~~~~
          <Windows.h>
 1 error generated.
 ninja: build stopped: subcommand failed.
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Try to track down available XCode versions (doctest#334)
6ab6e32 
Example output:
xcode-select: error: invalid developer directory '/Applications/Xcode_10.2.1.app'
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Try fixing pre-xcode-11.0 macOS builds (doctest#334)
1de7009 
The output includes:

The macOS virtual environment has been updated to Catalina (v10.15). Starting January 15th,
jobs that include the line 'runs-on: macOS-10.14' will fail to run and return a failed check suite.
Please update your workflow and change the line 'runs-on: macOS-10.14' to 'runs-on: macOS-latest'.
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Remove pre-xcode-11.0 macOS builds (doctest#334)
a26f83d 
There are no longer available.
See https://github.blog/changelog/2019-11-06-github-actions-macos-virtual-environment-updated-to-catalina/

which points to this:
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/virtual-environments-for-github-hosted-runners

Which says that these XCode versions are now available: 11.0, 11.1, 11.2, 11.2.1, 11.3
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Explicitly request xcode 11.0 and 11.3 (doctest#334)
896819b 
The currently-available versions are as follows, so pick the oldest and the newest
of these.

11.0, 11.1, 11.2, 11.2.1, 11.3
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Partially revert previous commit (doctest#334)
ab624e0 
11.0 does need to be specified to xcode-select as 11
@claremacrae claremacrae mentioned this issue Feb 7, 2020
Closed
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Fix Github Actions CI on Windows (doctest#334)
1410aaa 
The output was:

At D:\a\_temp\384af4b7-bfae-4079-891c-d5392beae9ba.ps1:5 char:10
+ cd build && ctest
+          ~~
The token '&&' is not a valid statement separator in this version.
+ CategoryInfo          : ParserError: (:) [], ParseException
+ FullyQualifiedErrorId : InvalidEndOfLine

I've split all 'cd build && ctest' lines, to avoid making future
edits error-prone
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Fix clang Github Actions CI on Windows (doctest#334)
0f3502a 
The output was:

AIn file included from ../examples/all_features/main.cpp:2:
 In file included from ../scripts/development_only\doctest/doctest.h:5:
 ../doctest/parts\doctest.cpp:142:10: error: non-portable path to file '<Windows.h>'; specified path differs in case from file name on disk [-Werror,-Wnonportable-system-include-path]
 #include <windows.h>
          ^~~~~~~~~~~
          <Windows.h>
 1 error generated.
 ninja: build stopped: subcommand failed.
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Try to track down available XCode versions (doctest#334)
827b113 
Example output:
xcode-select: error: invalid developer directory '/Applications/Xcode_10.2.1.app'
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Try fixing pre-xcode-11.0 macOS builds (doctest#334)
e1b267e 
The output includes:

The macOS virtual environment has been updated to Catalina (v10.15). Starting January 15th,
jobs that include the line 'runs-on: macOS-10.14' will fail to run and return a failed check suite.
Please update your workflow and change the line 'runs-on: macOS-10.14' to 'runs-on: macOS-latest'.
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Remove pre-xcode-11.0 macOS builds (doctest#334)
81b8a06 
There are no longer available.
See https://github.blog/changelog/2019-11-06-github-actions-macos-virtual-environment-updated-to-catalina/

which points to this:
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/virtual-environments-for-github-hosted-runners

Which says that these XCode versions are now available: 11.0, 11.1, 11.2, 11.2.1, 11.3
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Explicitly request xcode 11.0 and 11.3 (doctest#334)
3d5dfa9 
The currently-available versions are as follows, so pick the oldest and the newest
of these.

11.0, 11.1, 11.2, 11.2.1, 11.3
claremacrae added a commit to claremacrae/doctest that referenced this issue Feb 7, 2020
@claremacrae
Partially revert previous commit (doctest#334)
9147b2d 
11.0 does need to be specified to xcode-select as 11
@claremacrae claremacrae mentioned this issue Feb 7, 2020
Merged
onqtam pushed a commit that referenced this issue Feb 19, 2020
@claremacrae
Fix GitHub CI and add GitHub build badges (#336) - closes #334
68cfa75
@onqtam onqtam closed this as completed in 8df12f2 Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GitHub CI and add GitHub build badges claremacrae/doctest
1 participant
@claremacrae