Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include Windows.h in small caps to silence clang warnings #312

Closed
ghost opened this issue Nov 21, 2019 · 0 comments
Closed

include Windows.h in small caps to silence clang warnings #312

ghost opened this issue Nov 21, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Nov 21, 2019

this revert is not for the windows.h include

Then I got distracted by the issue description. Sorry.

Currently windows.h is included like this: #include <Windows.h> - does version 2.3.5 not work for you? If not - that could easily be changed.

Exactly. It has to be #include <windows.h> (small caps) to silence Clang using [-Werror,-Wnonportable-system-include-path]. Then it works on Windows/Linux X gcc/clang - each with very picky warning flags. I located three ill-formed includes. Will open a MR fixing that.

Originally posted by @suoniq in #263 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onqtam