ARM builds: FTBFS on armhf - error: cast from 'const char*' to 'const

[OdyX]

Description

Debian's reproducibility test builds indicate that the armhf build FTBFS:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/armhf/doctest.html

/build/1st/doctest-1.2.7+repack0/examples/exe_with_static_libs/../../doctest/doctest.h:1885:74: error: cast from 'const char*' to 'const doctest::detail::ContextBuilder::ICapture*' increases required alignment of target type [-Werror=cast-align]
                 reinterpret_cast<const ICapture*>(stackChunks[curr++].buf)->toStream(stream);
                                                                          ^
In file included from /build/1st/doctest-1.2.7+repack0/examples/exe_with_static_libs/lib_2_src.cpp:1:0:
/build/1st/doctest-1.2.7+repack0/examples/exe_with_static_libs/../../doctest/doctest.h: In member function 'void doctest::detail::ContextBuilder::build(std::ostream*) const':
/build/1st/doctest-1.2.7+repack0/examples/exe_with_static_libs/../../doctest/doctest.h:1885:74: error: cast from 'const char*' to 'const doctest::detail::ContextBuilder::ICapture*' increases required alignment of target type [-Werror=cast-align]
                 reinterpret_cast<const ICapture*>(stackChunks[curr++].buf)->toStream(stream);
                                                                          ^
/build/1st/doctest-1.2.7+repack0/examples/exe_with_static_libs/../../doctest/doctest.h:1889:71: error: cast from 'char*' to 'const doctest::detail::ContextBuilder::ICapture*' increases required alignment of target type [-Werror=cast-align]
                 reinterpret_cast<const ICapture*>(curr_elem->chunk.buf)->toStream(stream);
                                                                       ^
/build/1st/doctest-1.2.7+repack0/examples/exe_with_static_libs/../../doctest/doctest.h:1889:71: error: cast from 'char*' to 'const doctest::detail::ContextBuilder::ICapture*' increases required alignment of target type [-Werror=cast-align]
                 reinterpret_cast<const ICapture*>(curr_elem->chunk.buf)->toStream(stream);

• doctest version: v1.2.7
• Operating System: Debian sid
• Compiler+version: GNU 7.3.0

[onqtam]

I'll either suppress -Wcast-align or add the appropriate attribute to the char buffer. Will do in a few days though - when I get back home.

[onqtam]

should be fixed in version 1.2.8

[OdyX]

Thanks for your proposed fix, but it seems it wasn't sufficient, see: https://tests.reproducible-builds.org/debian/rbuild/unstable/armhf/doctest_1.2.8+repack0-1.rbuild.log

[onqtam]

silencing the problematic warning. the char buffer is already annotated to have the proper alignment - this is probably a misdiagnostic by the compiler and should be safe to silence

try it out from the dev branch and let me know if it works! And sorry for the delay