Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does this code ignore the data length returned #205

Open
SunHui2980 opened this issue Oct 20, 2022 · 1 comment
Open

Why does this code ignore the data length returned #205

SunHui2980 opened this issue Oct 20, 2022 · 1 comment

Comments

@SunHui2980
Copy link

SunHui2980 commented Oct 20, 2022

dataCount, oobCount, flags, _, err = syscall.Recvmsg(fd, b, oobBuffer, 0)

why dose this code ignore the dataCount from syscall.Recvmsg here, since the ORAN standard some messages have the indefinite length?

Is it OK that it discards the dataCount and creates a fixed length buffer in onos-e2t at the same time ?

https://github.com/onosproject/onos-e2t/blob/9ef17c884e94786226d4004ca0f7325b9cf11fc1/pkg/protocols/e2ap/conn.go#L20

https://github.com/onosproject/onos-e2t/blob/9ef17c884e94786226d4004ca0f7325b9cf11fc1/pkg/protocols/e2ap/conn.go#L155

@SunHui2980 SunHui2980 changed the title Why this code ignore Why does this code ignore Oct 20, 2022
@SunHui2980 SunHui2980 changed the title Why does this code ignore Why does this code ignore the data length returned Oct 20, 2022
@adibrastegarnia
Copy link
Collaborator

I am wondering if we increase the buffer size in onos-e2t, are we gonna hit the limit again? I am wondering if we should handle it at SCTP level. @SunHui2980 Increasing buffer size in onos-e2t is fine but perhaps you should think if we can address it in SCTP library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants