Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LS] Support for resolving access(account) #65

Closed
benbackend opened this issue Mar 20, 2022 · 2 comments · Fixed by #69
Closed

[LS] Support for resolving access(account) #65

benbackend opened this issue Mar 20, 2022 · 2 comments · Fixed by #69
Assignees

Comments

@benbackend
Copy link

Currently, when we use access modifier access(account), vscode extention will treat all these contracts to be deployed in separate accounts and report error.

As the contracts should already be defined in flow.json, it should be possible to resolve whether the contracts are going to be under the same account?

Adding this feature can help a lot!
Thank you.

@turbolent
Copy link
Member

This must likely be implemented in the language server and should probably take into account the flow.json configuration.

The type checker already supports this through a custom handler (sema.Config.MemberAccountAccessHandler)

@sideninja sideninja transferred this issue from onflow/vscode-cadence Jan 18, 2023
@sideninja sideninja changed the title Can flow team add support in resolving access(account) in vscode-cadence? [LS] Support for resolving access(account) Jan 18, 2023
@sideninja
Copy link
Contributor

@Bamthelearner @turbolent this is now implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants