Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update access modifiers from pub to access(all) #75

Closed
sisyphusSmiling opened this issue Jun 12, 2023 · 3 comments
Closed

Update access modifiers from pub to access(all) #75

sisyphusSmiling opened this issue Jun 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@sisyphusSmiling
Copy link
Collaborator

Description

pub will be removed in favor of access(all) in preparation for entitlements. As such, we should ensure that access modifiers are updated before mainnet deployment.

Suggested solution

Replace instances of pub with access(all) across the whole of this codebase.

@sisyphusSmiling sisyphusSmiling added the enhancement New feature or request label Jun 12, 2023
@sisyphusSmiling
Copy link
Collaborator Author

As @austinkline pointed out, we may wait on deploying contracts with updated access modifiers in favor of forcing a breaking update. The risk in updating pub with access(all) is that we'll introduce unknown vulnerabilities in a post-entitlement world that would otherwise be caught and tested locally before updating the broken contract in prod.

@austinkline
Copy link
Collaborator

@sisyphusSmiling should we close this one for now, since we won't take this up until entitlements are being released?

@sisyphusSmiling
Copy link
Collaborator Author

@austinkline yeah, not a pressing issue atm, so I'll close and we can reopen when it's relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants