Updates Core Contracts dependencies #5771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
requested review from
janezpodhostnik and
turbolent
and removed request for
ramtinms
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5771 +/- ##
==========================================================
- Coverage 53.33% 48.39% -4.94%
==========================================================
Files 324 149 -175
Lines 30045 18011 -12034
==========================================================
- Hits 16024 8717 -7307
+ Misses 12598 8603 -3995
+ Partials 1423 691 -732
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
|
Please tag teams instead of individuals 🙏 |
turbolent
approved these changes
Apr 24, 2024
SupunS
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Withdrawnevent toVaultand addbalanceAfterparams flow-ft#158ownedNFTsbeaccess(all): 4a6f42dLockedTokensto use an entitlement: Add entitlement for locked account creator flow-core-contracts#423This has not been tested with the Cadence versions that include the two new FLIPs onflow/flips#242 and onflow/flips#263, but I did search the all the code and verified that everything appears to be compatible, but I understand if we want to wait to merge this until we have verified with the new Cadence versions that use those changes. Let me know what you think!