Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Design error handling for web socket connection #6642

Open
Tracked by #6163
Guitarheroua opened this issue Nov 12, 2024 · 1 comment
Open
Tracked by #6163

[Access] Design error handling for web socket connection #6642

Guitarheroua opened this issue Nov 12, 2024 · 1 comment
Assignees
Labels

Comments

@Guitarheroua
Copy link
Contributor

Guitarheroua commented Nov 12, 2024

Develop a comprehensive error-handling strategy for WebSocket connections.

Requirements:

  1. Error Analysis:

    • Identify potential errors in the web socket controller and data providers.
    • Categorize errors into types such as:
      • Internal: Errors that should be logged but not exposed to users.
      • User-Reported: Errors that should be communicated back to the user.
      • Critical: Errors requiring immediate action, such as terminating the WebSocket connection.
  2. Error Handling:

    • Design a system to handle errors, ensuring consistent behaviour across the controller.
    • Define clear rules for:
      • Sending errors back to the user.
      • Logging internal errors.
      • Dropping the WebSocket connection in critical scenarios.
  3. Integration:

    • Ensure the error-handling mechanism integrates seamlessly with both the web socket controller and its associated data providers.
@Guitarheroua
Copy link
Contributor Author

WS connection close handler should be part of the error handling design. See https://github.com/onflow/flow-go/pull/6750/files#r1853825821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants