Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] move the gas estimate adjustments to Gateway instead of dryrun #6301

Closed
ramtinms opened this issue Aug 7, 2024 · 3 comments
Closed
Labels
Stale Label used when marking an issue stale.

Comments

@ramtinms
Copy link
Contributor

ramtinms commented Aug 7, 2024

Ideally dry run should report the actual amount of gas used and adjustments be made off-chain given adjustments logic will change from time to time and updating Gateway is easier

@m-Peter
Copy link
Collaborator

m-Peter commented Aug 7, 2024

The adjustment logic that we currently do is here: https://github.com/onflow/flow-go/blob/master/fvm/evm/emulator/emulator.go#L291-L308.
The EIP-150 is something that is relevant only for contract deployments:

Copy link
Contributor

github-actions bot commented Nov 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Nov 6, 2024
@m-Peter
Copy link
Collaborator

m-Peter commented Nov 6, 2024

This is being implemented by onflow/flow-evm-gateway#635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Label used when marking an issue stale.
Projects
None yet
Development

No branches or pull requests

2 participants