Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize computation of Leader Selection during EFM #6181

Open
AlexHentschel opened this issue Jul 5, 2024 · 1 comment
Open

Optimize computation of Leader Selection during EFM #6181

AlexHentschel opened this issue Jul 5, 2024 · 1 comment

Comments

@AlexHentschel
Copy link
Member

AlexHentschel commented Jul 5, 2024

PR comment suggesting dynamic leader extension

I think there might be value in consolidating the logic for the leader selections, purely for readability and encapsulation (reducing surface for possible bugs).

Def of done

provide an extendable leader selection, that in addition memorizes the rng and has a slice of extensions, where each extension is its own leader selection

  • we already have a binarySearchStrictlyBigger method that can be copied and extended to work on the extension and find the leader-selection, whose range contains the requested view
  • in documentation of binarySearchStrictlyBigger replace "non-decreasing" by "monotonically increasing" (for every indices i,j with i<j we must have arr[i] ≤ arr[j])
@AlexHentschel AlexHentschel self-assigned this Jul 5, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Oct 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2024
@AlexHentschel AlexHentschel removed the Stale Label used when marking an issue stale. label Nov 13, 2024
@AlexHentschel AlexHentschel changed the title 🚧[under construction]🚧 EFM committee Optimize computation of Leader Selection during EFM Nov 13, 2024
@AlexHentschel AlexHentschel reopened this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant