Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol KVStore] Move EpochProtocolState data into KVStore #5974

Open
Tracked by #5971 ...
jordanschalm opened this issue May 23, 2024 · 1 comment
Open
Tracked by #5971 ...

[Protocol KVStore] Move EpochProtocolState data into KVStore #5974

jordanschalm opened this issue May 23, 2024 · 1 comment
Labels
Preserve Stale Bot repellent Protocol Team: Issues assigned to the Protocol Pillar. S-BFT

Comments

@jordanschalm
Copy link
Member

jordanschalm commented May 23, 2024

At the moment we only store the hash of Epoch sub-state in the KVStore. We'd like to directly store all the data there instead.

Suggested implementation

  • keep original Snapshot.Epoch API, but back it by the KV-store (this prevents needing to update/refactor all existing usages)
  • no (remove) top-level "getter" Snapshot.EpochProtocolState
  • top-level access to Epoch-data is still given through KV-Store's canonical representation (interface according to the newest protocol version 👉 KVStoreReader)

Clean up duplicated epoch API at the same time?

Historically grown, the Epoch portion of the Protocol state is exposed in three different places in our APIs (see #5650 (comment)). We would like to consolidate this.

See also #6191

@jordanschalm jordanschalm added Protocol Team: Issues assigned to the Protocol Pillar. S-BFT labels May 23, 2024
@jordanschalm jordanschalm changed the title At the moment, we only commit the EpochProtocolState's Hash into the KV-Store -- we want to move the actual data into the KV-store Move EpochProtocolState data into KVStore May 23, 2024
@jordanschalm jordanschalm changed the title Move EpochProtocolState data into KVStore [Protocol KVStore] Move EpochProtocolState data into KVStore May 23, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Oct 8, 2024
@jordanschalm jordanschalm added Preserve Stale Bot repellent and removed Stale Label used when marking an issue stale. labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preserve Stale Bot repellent Protocol Team: Issues assigned to the Protocol Pillar. S-BFT
Projects
None yet
Development

No branches or pull requests

1 participant