Meter (and charge for) the transaction storage check

[janezpodhostnik]

Problem Definition

Storage Check¹ is un-metered. This is a problem, because users can control how long (complex) the storage check is.

If a transaction touches the registers of more accounts, then the storage check will be longer.

Proposed Solution

Meter the storage check as a normal part of the transaction.

The technical change is very simple, but this would mean that the computation used of transactions would change, so needs to be announced well in advance and we might want to bundle it with any other fee changes.

Release notes

Please make sure to mention this in the release notes. This will make all transactions a tiny bit more expensive, but transactions that touch a lot of accounts might be significantly more expensive.

This is change is needed to close a gap in metering.

Definition of Done

• [] The storage check is metered

Footnotes

1. The part of the transaction, where all account that had any of their storage registers changed, are checked if their storage capacity is more then their storage used. If not the transaction fails. ↩

[janezpodhostnik]

Could be released together with #5026

[j1010001]

waiting for a change to fees so we can deploy it together (could be in HCU)