-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary version #563
Comments
Maybe the following endpoint can be useful: curl -s -XPOST 'https://testnet.evm.nodes.onflow.org' --header 'Content-Type: application/json' --data-raw '{"jsonrpc":"2.0","method":"web3_clientVersion","params":[],"id":7}' | jq {
"jsonrpc": "2.0",
"id": 7,
"result": "[email protected]"
} But that also is specific to how the binary is being built. See: |
I build the binary with |
@Maharacha What if you build with: go build -o evm-gateway -ldflags="-X github.com/onflow/flow-evm-gateway/api.Version=$(git describe --tags --abbrev=0 2>/dev/null)" ./cmd/main/main.go Note that you need to have ran before: git fetch origin --tags I have tried this and it works: curl -s -XPOST 'localhost:8545' --header 'Content-Type: application/json' --data-raw '{"jsonrpc":"2.0","method":"web3_clientVersion","params":[],"id":1}' | jq
{
"jsonrpc": "2.0",
"id": 1,
"result": "[email protected]"
} |
@m-Peter yes that works, and is better than nothing! But it would be nice to be able to check the binary version without having to start the node. It is useful for troubleshooting in an environment where you have nodes that have crashed for whatever reasons. |
@Maharacha That is a good point indeed 👍 We'll work on a solution to provide that functionality. |
Thanks! And thanks for the workaround in the meantime! |
FYI.
Another problem with both |
Hmmm, interesting. If you can, please create a new issue for it 🙏 |
Is it correct that checking the version of the binary is not supported? E.g.
evm-gateway --version
. Is that something that can be added?The text was updated successfully, but these errors were encountered: