Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a gas price of 0 for the self-rolled transaction used on gas estimation #161

Closed
Tracked by #126
m-Peter opened this issue Mar 14, 2024 · 0 comments · Fixed by #176
Closed
Tracked by #126

Set a gas price of 0 for the self-rolled transaction used on gas estimation #161

m-Peter opened this issue Mar 14, 2024 · 0 comments · Fixed by #176
Assignees
Labels
Bug Something isn't working EVM Improvement
Milestone

Comments

@m-Peter
Copy link
Collaborator

m-Peter commented Mar 14, 2024

Since we use a random EOA address to sign a transaction for the eth_estimateGas endpoint, we need to set the GasPrice field to 0 as the EOA address does not have any funds and this will cause a validation error. See: https://github.com/onflow/flow-evm-gateway/blob/main/api/gas_estimation.go#L32. It might be a good idea to also hide the private key used in: https://github.com/onflow/flow-evm-gateway/blob/main/api/gas_estimation.go#L13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working EVM Improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant