Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Stable Cadence feature branch with main #35

Merged
merged 23 commits into from
Jan 31, 2024
Merged

Update Stable Cadence feature branch with main #35

merged 23 commits into from
Jan 31, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jan 31, 2024 •
edited
Loading

Merge main into feature/stable-cadence

bthaile and others added 23 commits January 8, 2024 13:03
@bthaile
consistently format addresses to be used when generation dependencies
e6fd302
@bthaile
Merge pull request #29 from onflow/format-addresses-0x
4ccac39 
consistently format addresses to be used when generation dependencies
@bthaile
add default output if one does not exist, add output when generating …
16366b5 
…v1.1 flix
@bthaile
Merge pull request #30 from onflow/fix-output-add-default
c721b51 
fix issue when output does not exist in template
@bthaile
impl binding generator interface, needed for mocking and better code …
6d5b607 
…structure
@bthaile
update to not having breaking changes
9cfc115
@chasefleming
Change codeowners
f3fb8ad
@bthaile
update naming of interfaces to be more consistent
70ef28c
@chasefleming
Merge pull request #32 from onflow/cf/change-codeowners
8731090 
Change codeowners
@bthaile
add conv method
ae405f9
@bthaile
set methods private that are no longer public
6cc3d9d
@ianthpun
update
0ecb51f
@ianthpun
Merge branch 'impl-interface-binding' into ianthpun/test
53ccd60
@ianthpun
update
fb7d76a
@ianthpun
update
3810160
@bthaile
restructuring for v2.0
1eee459
@bthaile
add unit tests, fix issue with creating binding file from template na…
5073f3c 
…me or id
@bthaile
condensed all functionality into one flix service
45a11e3
@bthaile
tweaks to support empty prefill template
d5b59fb
@bthaile
addressed PR comments
b926de9
@bthaile
update readme to reflex code changes
fcc06d7
@bthaile
Merge pull request #31 from onflow/impl-interface-binding
abbd351 
Reorganization of code and naming
@turbolent
Merge branch 'main' into bastian/update-stable-cadence
d566cfd
@turbolent turbolent requested a review from a team January 31, 2024 00:55
@turbolent turbolent mentioned this pull request Jan 31, 2024
Merged
bthaile
bthaile reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase branches. There have been a lot of changes after this branch was created.

@turbolent
Copy link
Member Author

@bthaile Can you elaborate? This very PR brings the feature branch up-to-date, by merging master into it. I created it today. What is missing?

bthaile
bthaile approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@turbolent turbolent merged commit d6a3015 into feature/stable-cadence Jan 31, 2024
@turbolent turbolent deleted the bastian/update-stable-cadence branch January 31, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthaile bthaile bthaile approved these changes

@chasefleming chasefleming Awaiting requested review from chasefleming

@bjartek bjartek Awaiting requested review from bjartek bjartek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turbolent @bthaile @chasefleming @ianthpun