This commit updates Cadence to use new Atree API
- Array.Get()
- OrderedMap.Get()
- MaxInlineArrayElementSize()
- MaxInlineMapKeySize()

For more info, see Atree PRs:
- onflow/atree#314
- onflow/atree#316
- onflow/atree#318

This commit updates Cadence to use new Atree API
- Array.SlabID()
- OrderedMap.SlabID()
- SlabID
- SlabIndex
- etc.

For more info, see Atree PRs:
- onflow/atree#322
- onflow/atree#323
- onflow/atree#324

Currently, Array.SlabID() and OrderedMap.SlabID() are used as
identifier to track resources, etc because slab IDs are guaranteed
to unique. However, atree slab ID should be only used to retrieve
slabs (registers) from storage.

Also, when Atree register inlining is implemented in the future, some
resources may not be stored in separate slabs, so they will not have
slab IDs anymore.

This commit uses Array.ValueID() and OrderedMap.ValueID() to uniquely
identify resources.

This commit updates Cadence to use newer version of onflow/atree
with register inlining and data deduplication features.

- Updated StorableDecoder callbacks

- Updated StringAtreeValue to implement atree.ComparableStorable

- Updated SomeStorable to implement atree.ContainerStorable

- Updated these structs to implement TypeInfo interface:
  * compositeTypeInfo
  * EmptyTypeInfo
  * VariableSizedStaticType
  * ConstantSizedStaticType
  * DictionaryStaticType

- Updated decodeStorable() to decode atree inlined array, map, and
  compact map

- Updated to use ReadOnly iterators when possible

- Updated to use NonReadOnly iterators

Co-authored-by: Bastian Müller <[email protected]>

Co-authored-by: Bastian Müller <[email protected]>

Co-authored-by: Supun Setunga <[email protected]>

…alues

…ows using read-only iterator

…tion in tests

…eturn shallow copy

Currently (in master), there are 4 cases of SomeStorable encoding:
- SomeStorable and its content are encoded inline
- SomeStorable is encoded inline while its content is encoded
  in separate slab when content size exceeds size limit
- SomeStorable and its content are encoded in separate slab
  when content size fits withinin size limit but SomeStorable
  plus its content size exceeds size limit
- SomeStorable and its content are encoded across multiple slabs
  when there are multiple nested SomeStorable and some of them
  exceeds size limit

Given this, adding Atree Inlining feature (onflow/atree PR 342) makes encoding
even more complicated for SomeStorable when it contains inlined array or map.

This commit simplifies encoding by removing the last 2 cases, so SomeStorable can be
encoded in two ways:
- if innermost value is too large, innermost value is encoded in a separate slab
  while SomeStorable wrapper is encoded inline with reference to slab containing
  innermost value.
- otherwise, SomeStorable with innermost value is encoded inline.

The above applies to both immutable innermost value (such as StringValue),
and mutable innermost value (such as ArrayValue).

Additionally, this commit also adds new efficient encoding for SomeStorable
when it has multiple nested levels (SomeStorable containing SomeStorable).

…ing them

Co-authored-by: Bastian Müller <[email protected]>

Cadence smoke test is reporting false alarm about
"slab was not reachable".

To summarize, storage.CheckHealth() should be called after
array.DeepRemove(), rather than in the middle of array.DeepRemove().

CheckHealth() is called in the middle of array.DeepRemove() when:
- array.DeepRemove() calls childArray1 and childArray2 DeepRemove()
- DeepRemove() calls maybeValidateAtreeValue()
- maybeValidateAtreeValue() calls CheckHealth()

The details are more complex than this oversimplified summary.

For more context, see comments/discussion on GitHub at
#2882 (comment)

…f at root

…idation at root of deep remove

Cadence smoke test reported another false alarm about
"slab was not reachable".

To summarize, storage.CheckHealth() should be called after
DictionaryValue.Transfer() with remove flag, rather than
in the middle of DictionaryValue.Transfer() with remove flag.

The details are more complex than this oversimplified summary.

For more context, see GitHub comments at
#2882 (comment)

This commit adds a new parameter atRoot to Transfer().  Atree storage
is validated only if both remove and atRoot parameters are true in
ArrayValue.Transfer(), DictionaryValue.Transfer(), and
CompositeValue.Transfer().

Currently in ArrayValue.Transfer(), DictionaryValue.Transfer(),
and CompositeValue.Transfer() if remove parameter is true:
- atree storage is validated
- container slab is removed

However, when transferring nested ArrayValue, DictionaryValue,
and CompositeValue with remove flag, atree storage validation can
fail because child slab is removed while parent container is not
reset completely yet.

This validation problem is similar to the previously fixed
atree storage validation problem during nested DeepRemove().

If remove parameter is true in Transfer(), iterated values are
removed so non-readonly iterators need to be used.

- Renamed atRoot param to hasNoParentContainer for Transfer() and
  DeepRemove()
- Added comments for each instances of hasNoParentContainer for
  Transfer()
- For SomeValue.Transfer() and PublishedValue.Transfer(), use
  received hasNoParentContainer argument as inner value's
  Transfer() parameter

For SomeValue.DeepRemove(), PathCapabilityValue.Transfer(),
and IDCapabilityValue.DeepRemove(), use received
hasNoParentContainer argument as inner value's DeepRemove()
parameter.

Also, add comments for hasNoParentContainer in DeepRemove().

Co-authored-by: Faye Amacker <[email protected]>

Entitlement migration was broken because new dictionary value
was created with zero address using NewDictionaryValue().

This commit fixes entitlement migration by creating new dictionary
value with owner address using NewDictionaryValueWithAddress().

This commit bumps atree version to benefit from deduplication
of atree inlined Cadence dictionary type info.

For more info, see
onflow/atree#369

…/atree-inlining-merge-master

…://github.com/onflow/cadence into supun/atree-inlining-merge-master

…inlining-v1.0

  Bump atree version in Cadence v1.0 for new features (e.g. deduplication of Cadence dictionary type info)

Currently, we are not sure if all uses can be guaranteed to
be readonly in two functions, so this commit uses atree
non-readonly iterators in:
- CompositeValue.ForEachFieldName
- DictionaryValue.IterateKeys

Also added TODO to determine if all uses can be guaranteed to be
readonly for these, which would allow us to revert this change.

…rators

Use atree readonly iterators when mutation of values is not needed

…v1.0

Sync atree inlining branch with master

…read-only iterator

…y are read-only

…lining-v1.0

…ove-atree-register-inlining-v1.0

…nlining-v1.0

This bumps onflow/atree version to latest feature branch
for atree inlining and deduplication.

…rsion-for-cadence-v1.0

Bump onflow/atree to latest version in feature/atree-register-inlining-v1.0

…ining-v1.0

…lining-v1.0

…lining-v1.0

…atree-register-inlining-v1.0

…lining-v1.0-2

…lining-v1.0-3

The problem was initially detected in testnet migration
of atree inlined data with Cadence 1.0 migration.

The bug  happened with 5 nested levels of data while
this reproducer is simplified to use 3 nested levels.

More info at:
#3288

This commit fixes Cadence 1.0 migration when
using atree inlined data. See issue:

  #3288

Previously, MigrateNestedValue() migrates dictionary by using
readonly iterator and migrating values in place.

This commit migrates keys first using readonly iterator and
then migrates values using mutable iterator.

Fix Cadence 1.0 migration of dictionary values when using atree inlined data