Concretize the definition of Primitive type #2962
Conversation
darkdrag00nv2
requested review from
turbolent,
SupunS and
dsainati1
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #2962 +/- ##
==========================================================
- Coverage 80.11% 80.07% -0.04%
==========================================================
Files 348 348
Lines 81870 81915 +45
==========================================================
+ Hits 65590 65594 +4
- Misses 13958 13998 +40
- Partials 2322 2323 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
runtime/sema/gen/main.go
Outdated
| @@ -1583,12 +1584,14 @@ func simpleTypeLiteral(ty *typeDecl) dst.Expr { | |||
| //} | |||
|
|
|||
| isResource := ty.compositeKind == common.CompositeKindResource | |||
| _, isPrimitive := sema.GeneratedPrimitiveSimpleTypes[ty.typeName] | |||
There was a problem hiding this comment.
Similar to how other "kind"s are indicated through conformances in declarations of built-in types which produce Go code, like if a type is storable via conforming to the Storable type (also, Equatable, Comparable, etc), we might consider introducing a Primitive type in the code generator (which later then also could be introduced "properly" in the type checker.
There was a problem hiding this comment.
Done in 7b3805c.
runtime/sema/simple_type.go
Outdated
| @@ -25,6 +25,10 @@ import ( | |||
| "github.com/onflow/cadence/runtime/common" | |||
| ) | |||
|
|
|||
| var GeneratedPrimitiveSimpleTypes = map[string]bool{ | |||
There was a problem hiding this comment.
As commented above, maybe consider replacing this with a notion of Primitive in the code generator. It's difficult to see that a side-table determines additional properties of a type.
There was a problem hiding this comment.
Done in 7b3805c.
runtime/sema/type.go
Outdated
| @@ -669,6 +674,10 @@ func (t *OptionalType) IsResourceType() bool { | |||
| return t.Type.IsResourceType() | |||
| } | |||
|
|
|||
| func (t *OptionalType) IsPrimitiveType() bool { | |||
| return false | |||
There was a problem hiding this comment.
Could you please add a test case here and for the other uncovered functions below?
There was a problem hiding this comment.
What sort of test would make sense here? We are not using this IsPrimitiveType function anywhere. Is there a place where we could use it and then that would automatically lead to coverage?
darkdrag00nv2
force-pushed
the
define_primitives
branch
from
e2ab9ed to
61e79f1
Compare
Closes #2929
Description
This PR concretizes the definition of Primitive type by introducing a
IsPrimitiveTypefunction onsema.Type.The following types have been marked as primitive:
NumbertypesCharacterBoolStringAddressPathVoidOptional<T>- ifTis primitivemasterbranchFiles changedin the Github PR explorer