Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enums in Contract Interfaces cannot be updated to Cadence 1.0 #3182

Closed
dsainati1 opened this issue Mar 19, 2024 · 0 comments · Fixed by #3197
Closed

Enums in Contract Interfaces cannot be updated to Cadence 1.0 #3182

dsainati1 opened this issue Mar 19, 2024 · 0 comments · Fixed by #3197
Assignees
Labels
Bug Something isn't working

Comments

@dsainati1
Copy link
Contributor

Issue to be solved

Enums were previously allowed in contract interfaces as a type requirement, but with the removal of type requirements they are no longer allowed to appear there. However, there is no current migration path for any old enums of this kind, as there are no enum interfaces to update them to, and the update validator does not allow the removal of a type declaration.

Suggested Solution

We should either allow enum declarations to be removed from contract interfaces (which should be safe because the enum will be declared in all contracts that conform to that interface) or come up with an alternative data migration to support this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants