You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the suggested fixes for pub and priv access modifiers are surrounded in backticks (i.e. `access(all)` or `access(self)`)
This is technically not the semantically correct correction to the token and is problematic for external consumers of these suggestions (i.e. Language Server) which seek to actually apply this correction, but produce invalid Cadence when doing so.
There should be no backticks. It should be up to external clients to encapsulate the suggestion in any formatting if they wish to do so as this is fairly trivial & the raw suggestion is much more important.
Current Behavior
Currently, the suggested fixes for
pub
andpriv
access modifiers are surrounded in backticks (i.e.`access(all)`
or`access(self)`
)This is technically not the semantically correct correction to the token and is problematic for external consumers of these suggestions (i.e. Language Server) which seek to actually apply this correction, but produce invalid Cadence when doing so.
cadence/runtime/parser/declaration.go
Lines 284 to 287 in 3adb033
cadence/runtime/parser/declaration.go
Lines 298 to 302 in 3adb033
Expected Behavior
There should be no backticks. It should be up to external clients to encapsulate the suggestion in any formatting if they wish to do so as this is fairly trivial & the raw suggestion is much more important.
Steps To Reproduce
Try replacing
pub
orpriv
in VSCode extensionresults in...
Environment
The text was updated successfully, but these errors were encountered: