fix regression introduced in a250336: gracefully handle invalid restr…

…ictions
onflow · Nov 16, 2021 · 53ddeff · 53ddeff
1 parent ad6895c
commit 53ddeff
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/runtime/sema/checker.go b/runtime/sema/checker.go
@@ -1141,6 +1141,10 @@ func (checker *Checker) convertRestrictedType(t *ast.RestrictedType) Type {
 					Range: ast.NewRangeFromPositioned(restriction),
 				})
 			}
+
+			// NOTE: ignore this invalid type
+			// and do not add it to the restrictions result
+			continue
 		}
 
 		restrictions = append(restrictions, restrictionInterfaceType)

diff --git a/runtime/tests/checker/restriction_test.go b/runtime/tests/checker/restriction_test.go
@@ -1124,3 +1124,17 @@ func TestCheckRestrictedConformance(t *testing.T) {
 
 	require.NoError(t, err)
 }
+
+func TestCheckInvalidRestriction(t *testing.T) {
+
+	t.Parallel()
+
+	_, err := ParseAndCheck(t, `
+      let x: {h} = nil
+    `)
+
+	errs := ExpectCheckerErrors(t, err, 2)
+
+	require.IsType(t, &sema.NotDeclaredError{}, errs[0])
+	require.IsType(t, &sema.AmbiguousRestrictedTypeError{}, errs[1])
+}