feat(npm): add types and sass variables #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posthardcode
approved these changes
May 13, 2021
josokinas
force-pushed
the
feat/types-and-sass-variables
branch
from
d8e5245 to
5c80e6a
Compare
|
Since it's not auto generated, do we have to manually curate these when a token is added/removed/changed? |
josokinas
force-pushed
the
feat/types-and-sass-variables
branch
from
5c80e6a to
a8d286c
Compare
|
@rabelloo I have reworked this now so that Theo auto-generates all the definitions. Let me know how does it look now. |
josokinas
force-pushed
the
feat/types-and-sass-variables
branch
2 times, most recently
from
8aef843 to
f181436
Compare
rabelloo
reviewed
May 17, 2021
rabelloo
reviewed
May 17, 2021
rabelloo
reviewed
May 17, 2021
josokinas
force-pushed
the
feat/types-and-sass-variables
branch
3 times, most recently
from
a8270aa to
76403ea
Compare
josokinas
force-pushed
the
feat/types-and-sass-variables
branch
from
76403ea to
62bb8f4
Compare
rabelloo
reviewed
May 18, 2021
rabelloo
approved these changes
May 18, 2021
josokinas
force-pushed
the
feat/types-and-sass-variables
branch
from
62bb8f4 to
34c013e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add types and Sass variables of all (base and theme) tokens available.
Approach
Auto-generate TypeScript types and Sass variables, make them accessible via
index.tsandindex.scss.Testing
When integrating with Castor.
Risks
N/A