-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always get the origin image #328
Labels
Comments
The only difference is // version 1.8.5
func kfe_setRoundImageWithURLString(URLString: String?, cornerRadiusRatio: CGFloat? = nil, options: KingfisherManager.Options = KingfisherManager.DefaultOptions, progressBlock: ImageDownloaderProgressBlock? = nil) { ... }
// version 2.4.1
func kfe_setRoundImageWithURLString(URLString: String?, cornerRadiusRatio: CGFloat? = nil, options: KingfisherOptionsInfo? = nil, progressBlock: ImageDownloaderProgressBlock? = nil) { ... }
// version 1.8.5
func kfe_setImageWithURLString(URLString: String?,
placeholderImage: UIImage?,
optionsInfo: KingfisherOptionsInfo?,
progressBlock: DownloadProgressBlock?,
completionHandler: CompletionHandler?) -> RetrieveImageTask?
{
...
let defaultOptions: KingfisherOptionsInfo = [
.Options([.BackgroundDecode, .LowPriority]),
.Transition(ImageTransition.Fade(0.55))
]
...
}
// version 2.4.1
func kfe_setImageWithURLString(URLString: String?,
placeholderImage: UIImage?,
optionsInfo: KingfisherOptionsInfo?,
progressBlock: DownloadProgressBlock?,
completionHandler: CompletionHandler?) -> RetrieveImageTask?
{
...
let defaultOptions: KingfisherOptionsInfo = [
.BackgroundDecode,
.DownloadPriority(NSURLSessionTaskPriorityLow),
.Transition(ImageTransition.Fade(0.55))
]
...
} |
Version 2.4.1 |
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, thanks for the open source.
I use this below which version is 1.8.5, when I restart the App, I can get the round image
https://github.com/Limon-O-O/KingfisherExtension/blob/master/KingfisherExtension/UIImageView%2BExtension.swift#L22-#L50
But when I update the Kingfisher to the last version 2.4.1, and change code to this below. Then I restart the App, I always get the origin image(which is not cropped).
It seems that the cache system always store the origin image to disk.
The text was updated successfully, but these errors were encountered: