Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SP Key Rollover - Publish future SP x509 Certificate in Metadata #240

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Support SP Key Rollover - Publish future SP x509 Certificate in Metadata #240

merged 2 commits into from
Sep 12, 2019

Conversation

Chandra158
Copy link
Contributor

No description provided.

@Chandra158 Chandra158 mentioned this pull request Sep 12, 2019
Closed
@Chandra158
Copy link
Contributor Author

Sample SP Metadata with both certificates

SPCertNew

@pitbulk
Copy link
Contributor

pitbulk commented Sep 12, 2019

The code looks ok, I added a comment to make a minor addition to keep backward compatibility.

@pitbulk
Copy link
Contributor

pitbulk commented Sep 12, 2019

👍

@pitbulk pitbulk merged commit a251f01 into SAML-Toolkits:master Sep 12, 2019
@coveralls
Copy link

coveralls commented Sep 16, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 95.053% when pulling f404fb0 on ProcrastinatorCp:ticket-spKeyRollOver into 42700cc on onelogin:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitbulk pitbulk pitbulk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chandra158 @pitbulk @coveralls