Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone #1 #2

Open
Suzii opened this issue Oct 26, 2018 · 0 comments
Open

Milestone #1 #2

Suzii opened this issue Oct 26, 2018 · 0 comments

Comments

@Suzii
Copy link

Suzii commented Oct 26, 2018

Status: ✔️

Below are just suggestions to consider for the next milestones.

Propbably the nicest UI I have seen.
Wonderful usage of typescript, very nice and clean code.
Keep up the good work in the next milestones ;)
 

Code suggestions

  • Use combineReducers()
  • I am not sure what your intentions are but I would merge ChatLayout and ChatPage components into one.
  • Channels container - wrong typing of mapStateToProps function.
  • Use uuid instead of Math.random()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Suzii