-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can the timer be turned off; or, can it be shown on the game? #7
Comments
Hi @cyberkev63, sorry for your game that got canceled. I understand it must have been unpleasant. I had a look in the source code to discover that the server automatically closes games that have been idle for 10 minutes. I suppose I could increase that to 20 or 30, what do you think? |
Sorry to be slow to reply! Thank you for getting back to me (and so quickly)! |
Hi @cyberkev63, I have adjusted the timeout to 30 minutes. I am not closing this issue ATM, becasue updating the code revealed the following Deno issue that is currently preventing me from commiting the fix. Will close once this gets resolved.
Thanks! |
@ondras denoland/deno#7217 is now resolved. |
Great! Now onto the issue. The concept of the "garbage collection timer" is necessary, because if we want to enable re-connects, we cannot simply erase the game once all players have disconnected. On the other hand, I see no performance-related reason to pick the timer interval value that is so small that it limits the player experience. The timer obviously prevents memory hogs and DoS attacks, but these have been - so far, fortunately - purely theoretical aspects. I would suggest setting the timer to a value that is high enough that it does not limit anyone: an hour? two? a day? Suggestions? (I see no real point in displaying the value, though: it changes often and is an implementation detail; players should not be bothered by its existence.) |
I'd personally like it to be a day. |
A day it is then! @cyberkev63 would you find this value sufficient? |
I tend to be a slower player. (I like to think of it as "more thoughtful"...) [grin]
I ran into an issue in an online multiplayer with a friend where the game was canceled just as I was about to end a round.
Can the timer be turned off, or set longer?
Or, can it be shown on the game?
Or, at least, can we know what the timer is set to?
(Otherwise, great implementation of the game, by the way!)
The text was updated successfully, but these errors were encountered: