Allow local search on paginated async select component #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@ciremusyoka we need to fetch all the data before attempting to search client side, is that something that is handled here.
This is handled in the PaginatedAsyncSelect component |
ciremusyoka
force-pushed
the
update-paginated-select
branch
from
d356af3 to
627c949
Compare
peterMuriuki
reviewed
Jun 5, 2024
Comment on lines
181
to
182
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| fetchNextPage(); |
There was a problem hiding this comment.
@ciremusyoka how would this behave for an error on next page, does useInfiniteQuery catch that
ciremusyoka
force-pushed
the
update-paginated-select
branch
from
94e31db to
247c0b4
Compare
ciremusyoka
force-pushed
the
update-paginated-select
branch
2 times, most recently
from
b9aec5e to
6b8d7d8
Compare
ciremusyoka
force-pushed
the
update-paginated-select
branch
from
6b8d7d8 to
20510c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1380
Changes included with this PR
Checklist