Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHIR validation has an issue sorting changed files from Github #48

Closed
Wambere opened this issue Sep 14, 2023 · 2 comments
Closed

FHIR validation has an issue sorting changed files from Github #48

Wambere opened this issue Sep 14, 2023 · 2 comments
Assignees
Labels
efsity FCT features

Comments

@Wambere
Copy link
Contributor

Wambere commented Sep 14, 2023

Example: https://github.com/onaio/fhir-resources/actions/runs/6186171531/job/16793246787?pr=2679

Actual Error:

Error: There was an issue sorting changed files from Github.
Exception: {
  "error": "500/TypeError",
  "from": "sortChangedFiles",
  "message": "There was an issue sorting files changed.",
  "payload": "{}"
}
@Wambere Wambere self-assigned this Sep 14, 2023
@Wambere
Copy link
Contributor Author

Wambere commented Sep 14, 2023

Linked to:

Issue seems to be cause by renaming files
Looks like this has been fixed in version 1.2.4
However, version 1.2.4 is broken which is why we are using 1.2.3 in the first place

I'll attempt switching to 1.2.4 again and see if I can get it to work

@Wambere Wambere added the efsity FCT features label Sep 14, 2023
@Wambere
Copy link
Contributor Author

Wambere commented Oct 4, 2023

Tested this with this PR
Files handled correctly as expected

@Wambere Wambere closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efsity FCT features
Projects
None yet
Development

No branches or pull requests

1 participant