Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence of the property list with missing or same name #865

Open
4 tasks done
fredericalpers opened this issue Jul 24, 2024 · 2 comments · May be fixed by #876
Open
4 tasks done

Persistence of the property list with missing or same name #865

fredericalpers opened this issue Jul 24, 2024 · 2 comments · May be fixed by #876
Assignees
Labels
bug Indicates an unexpected problem or unintended behaviour component: address list Issue, Pull Request or Discussion related to address lists component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms component: property list Issue, Pull Request or Discussion related to property lists component: unit list Issue, Pull Request or Discussion related to unit lists QA Issue or Pull request that is in review

Comments

@fredericalpers
Copy link
Member

fredericalpers commented Jul 24, 2024

Persistence of the property list with missing or same name

Introduction

If a new property list is created and an attempt is made to save it without a name or with a name that is the same as an existing list, all the settings made are deleted. The error “There was a problem saving the list. The Name field must not be empty.” is displayed.

User Story

As a real estate agent, I want to make sure that all my changes to a new property listing are retained, even if I forget to give the listing a name, so that I don't lose any data and don't have to repeat my work unnecessarily.

This change ensures that users do not lose any data when creating real estate listings and can therefore work more efficiently.

Task / Requirements

  • When trying to save the list, the error message should still be displayed, but there should no longer be an automatic page reload
  • Implementation of notifications for unsaved changes Feature
  • If the name is empty: The Name field must not be empty. Do you want to leave the page without saving? [Link]Leave without saving[/Link].
  • If the name is the same: Please make sure that no other view with this name exists, even if it has a different type. Do you want to leave the page without saving? [Link]Leave without saving[/Link].
@fredericalpers fredericalpers added bug Indicates an unexpected problem or unintended behaviour component: property list Issue, Pull Request or Discussion related to property lists component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms component: unit list Issue, Pull Request or Discussion related to unit lists component: address list Issue, Pull Request or Discussion related to address lists labels Jul 24, 2024
@fredericalpers fredericalpers added this to the v5.6 milestone Jul 24, 2024
@yeneastgate yeneastgate self-assigned this Aug 5, 2024
@dai-eastgate
Copy link
Contributor

@fredericalpers I have implemented this issue. Here is evidence, please check it and let me know your opinion. Thanks!

865_demo.mp4

@fredericalpers
Copy link
Member Author

@dai-eastgate this seems to be working as intendet now, thank you! :) we will review this as soon as possible

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Aug 8, 2024
@fredericalpers fredericalpers removed this from the v5.6 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behaviour component: address list Issue, Pull Request or Discussion related to address lists component: contact form Issue, Pull Request or Discussion related to contact forms component: interest form Issue, Pull Request or Discussion related to interest forms component: owner form Issue, Pull Request or Discussion related to owner forms component: property list Issue, Pull Request or Discussion related to property lists component: unit list Issue, Pull Request or Discussion related to unit lists QA Issue or Pull request that is in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants